Runner.profile#11
Closed
stsoe wants to merge 4 commits into
Closed
Conversation
This WIP. Adding execution profile data that constraints how a run recipe is executed by the xrt::runner class. The profile is a separate json that is paired with a recipe when instantiating an xrt::runner. The profile is optional, while the recipe is required. The application can use the xrt::runner APIs to bind external resources or use the profile json to specify the binding and otherwise constaint the execution of a recipe. Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com>
Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com>
Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com>
The std::vector return type by reference was awkward. Should really be a std::span (c++20). Update xrt::xclbin ctor to with std::string_view. Add comments to runner.cpp. Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| : base_dir{"."} | ||
| {} | ||
|
|
||
| file_repo(std::filesystem::path basedir) |
There was a problem hiding this comment.
warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [hicpp-explicit-conversions]
Suggested change
| file_repo(std::filesystem::path basedir) | |
| explicit file_repo(std::filesystem::path basedir) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Documentation impact (if any)