refactor: reduce array copies in OpenApiSchemaConverter#33
Merged
Conversation
…maConverter Change convertRecursive, handleNullable, handlePrefixItems, and removeKeys to accept arrays by reference instead of by value. This eliminates intermediate array copies created at each transformation step during recursive schema conversion, reducing memory allocations for deeply nested OpenAPI schemas.
Verify that convert() does not mutate the caller's input array, ensuring the in-place optimization is safely encapsulated behind the value-passed public API boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convertRecursive,handleNullable,handlePrefixItems,removeKeysを参照渡しに変更し、中間配列コピーを削減Test plan
OpenApiSchemaConverterTest全テスト通過OpenApiResponseValidatorTest全テスト通過ResponseValidationTest(Integration) 全テスト通過