refactor: replace JSON roundtrip with direct array-to-object conversion#34
Merged
refactor: replace JSON roundtrip with direct array-to-object conversion#34
Conversation
…bject conversion Replace json_encode() → json_decode() roundtrip in OpenApiResponseValidator with a recursive toObject() helper that directly converts PHP arrays to stdClass objects. This eliminates temporary JSON string allocations that doubled memory usage for large response bodies and schemas during validation.
Verify that the toObject() helper produces structurally identical output to json_decode(json_encode()) across 17 edge cases: scalars, empty arrays, sequential/associative arrays, non-sequential integer keys, deeply nested structures, and mixed types.
wadakatu
force-pushed
the
refactor/remove-json-roundtrip
branch
from
1a5a672 to
e9fc6cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenApiResponseValidatorでjson_encode()→json_decode()の往復を廃止toObject()ヘルパーで PHP 配列を直接 stdClass に変換するように変更Test plan
OpenApiResponseValidatorTest全テスト通過ResponseValidationTest(Integration) 全テスト通過