Refactoring: OpenApiResponseValidator のキャッシュ最適化#36
Merged
Conversation
…nces Instead of recreating PathMatcher, opis Validator, and ErrorFormatter on every validate() call, cache them at the instance level in OpenApiResponseValidator. Also add a static validator cache in the ValidatesOpenApiSchema trait to avoid reconstructing the validator on every assertion, with resetValidatorCache() for test isolation.
Use ?int with null instead of int with -1 to represent the "no cached value" state, consistent with $cachedValidator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
OpenApiResponseValidator::validate()が呼ばれるたびにOpenApiPathMatcher・opisValidator・ErrorFormatterを毎回新規生成していた非効率を解消し、インスタンスレベル/静的キャッシュを導入。変更内容
OpenApiResponseValidator:ValidatorとErrorFormatterをコンストラクタで1回だけ生成するようにし、OpenApiPathMatcherを spec 名ごとにキャッシュするgetPathMatcher()を追加ValidatesOpenApiSchematrait: 静的キャッシュ ($cachedValidator) を導入し、maxErrorsが変わらない限り同じバリデータインスタンスを再利用。テスト用にresetValidatorCache()を追加tearDown()にself::resetValidatorCache()を追加してテスト間の分離を担保関連情報
OpenApiSpecLoaderキャッシュ最適化に続くパフォーマンス改善