Extract matchByName() utility and refactor resolve logic (#74)#80
Merged
titouanmathis merged 1 commit intomainfrom Feb 27, 2026
Merged
Extract matchByName() utility and refactor resolve logic (#74)#80titouanmathis merged 1 commit intomainfrom
titouanmathis merged 1 commit intomainfrom
Conversation
Extract shared case-insensitive name matching into a reusable matchByName() utility in forge-core. Refactor both core resolve executors and CLI resolve functions to use it, eliminating duplicated matching logic. Closes #74 Co-authored-by: Claude <claude@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
- Coverage 99.80% 99.80% -0.01%
==========================================
Files 223 224 +1
Lines 3596 3591 -5
Branches 833 833
==========================================
- Hits 3589 3584 -5
Misses 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74
Extract the shared
matchByName()utility from inline resolve logic intopackages/core/src/utils/name-matcher.ts. Both server and site resolve executors now use this shared function.Rebased onto main after #72 was merged.
Supersedes #79 (auto-closed when target branch was deleted).