Add auto-resolve for names in server_id/site_id across all MCP calls (#75)#81
Merged
titouanmathis merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
Add transparent name resolution middleware in executeToolWithCredentials. When server_id or site_id is non-numeric, it is automatically resolved to a numeric ID before routing to the handler. Zero changes to handlers or executors. Server_id resolves first since site resolution requires a numeric server_id. The resolve action itself skips auto-resolution. Closes #75 Co-authored-by: Claude <claude@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage 99.80% 99.80%
=======================================
Files 223 224 +1
Lines 3596 3629 +33
Branches 833 824 -9
=======================================
+ Hits 3589 3622 +33
Misses 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75
Adds transparent name→ID resolution in
executeToolWithCredentials()middleware. Whenserver_idorsite_idcontains a non-numeric string, the system automatically resolves it to the matching server/site ID before routing to handlers.resolveaction (which handles its own name resolution)Rebased onto main after #72 was merged.
Supersedes #77 (auto-closed when target branch was deleted).