Skip to content

refactor!: move error handler to schema#611

Draft
stuebingerb wants to merge 1 commit intofeature/support-partial-responsesfrom
refactor/move-error-handler-to-schema
Draft

refactor!: move error handler to schema#611
stuebingerb wants to merge 1 commit intofeature/support-partial-responsesfrom
refactor/move-error-handler-to-schema

Conversation

@stuebingerb
Copy link
Copy Markdown
Owner

Moves the error handler from the Ktor plugin to the schema itself. The error handler can now be used to map any exception encountered during execution and delegate to the default implementation.

BREAKING CHANGE: error handler is no longer supported as part of Ktor plugin configuration

Moves the error handler from the Ktor plugin to the schema itself. The
error handler can now be used to map any exception encountered during
execution and delegate to the default implementation.

BREAKING CHANGE: error handler is no longer supported as part of Ktor
plugin configuration
@stuebingerb stuebingerb force-pushed the refactor/move-error-handler-to-schema branch from 3099697 to 969f4cb Compare April 15, 2026 15:55
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.13%. Comparing base (c70d308) to head (969f4cb).

Files with missing lines Patch % Lines
.../main/kotlin/com/apurebase/kgraphql/KtorFeature.kt 0.00% 1 Missing ⚠️
...purebase/kgraphql/schema/execution/ErrorHandler.kt 85.71% 0 Missing and 1 partial ⚠️
...raphql/schema/execution/ParallelRequestExecutor.kt 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           feature/support-partial-responses     #611      +/-   ##
=====================================================================
+ Coverage                              84.09%   84.13%   +0.03%     
=====================================================================
  Files                                    151      152       +1     
  Lines                                   4999     5005       +6     
  Branches                                 861      862       +1     
=====================================================================
+ Hits                                    4204     4211       +7     
  Misses                                   495      495              
+ Partials                                 300      299       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

🐰 Bencher Report

Branchrefactor/move-error-handler-to-schema
Testbedubuntu-latest

🚨 1 Alert

BenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Lower Boundary
(Limit %)
com.apurebase.kgraphql.RequestCachingBenchmark.invalidRequestThroughput
operations / second (ops/s) x 1e3
📈 plot
🚷 threshold
🚨 alert (🔔)
137.38 ops/s x 1e3
(-38.63%)Baseline: 223.85 ops/s x 1e3
193.88 ops/s x 1e3
(141.12%)

Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s)
(Result Δ%)
Lower Boundary
operations / second (ops/s)
(Limit %)
com.apurebase.kgraphql.FunctionExecutionBenchmark.benchmarkFunctionExecution📈 view plot
🚷 view threshold
6,045,704.98 ops/s
(+3.23%)Baseline: 5,856,617.11 ops/s
5,174,367.27 ops/s
(85.59%)
com.apurebase.kgraphql.ParallelExecutionBenchmark.queryBenchmark📈 view plot
🚷 view threshold
1.30 ops/s
(-0.01%)Baseline: 1.30 ops/s
1.30 ops/s
(99.79%)
com.apurebase.kgraphql.QueryBenchmark.executionError📈 view plot
🚷 view threshold
16,060.68 ops/s
(-5.53%)Baseline: 17,000.81 ops/s
11,428.24 ops/s
(71.16%)
com.apurebase.kgraphql.QueryBenchmark.inputFromDocument📈 view plot
🚷 view threshold
19,540.78 ops/s
(-11.17%)Baseline: 21,996.79 ops/s
15,519.96 ops/s
(79.42%)
com.apurebase.kgraphql.QueryBenchmark.inputFromVariable📈 view plot
🚷 view threshold
18,462.04 ops/s
(-11.71%)Baseline: 20,911.60 ops/s
14,934.37 ops/s
(80.89%)
com.apurebase.kgraphql.QueryBenchmark.largeList📈 view plot
🚷 view threshold
4.67 ops/s
(+4.50%)Baseline: 4.47 ops/s
3.88 ops/s
(83.06%)
com.apurebase.kgraphql.QueryBenchmark.largeListWithFragment📈 view plot
🚷 view threshold
5.23 ops/s
(+5.59%)Baseline: 4.95 ops/s
4.32 ops/s
(82.67%)
com.apurebase.kgraphql.QueryBenchmark.manyChildren📈 view plot
🚷 view threshold
185.58 ops/s
(-0.68%)Baseline: 186.84 ops/s
153.29 ops/s
(82.60%)
com.apurebase.kgraphql.QueryBenchmark.manyChildrenWithFragment📈 view plot
🚷 view threshold
206.79 ops/s
(-1.85%)Baseline: 210.68 ops/s
167.33 ops/s
(80.92%)
com.apurebase.kgraphql.QueryBenchmark.manyDataChildren📈 view plot
🚷 view threshold
8.96 ops/s
(+0.28%)Baseline: 8.93 ops/s
8.84 ops/s
(98.64%)
com.apurebase.kgraphql.QueryBenchmark.manyOperations📈 view plot
🚷 view threshold
310.98 ops/s
(+11.14%)Baseline: 279.80 ops/s
224.60 ops/s
(72.22%)
com.apurebase.kgraphql.QueryBenchmark.manyOperationsWithFragment📈 view plot
🚷 view threshold
317.23 ops/s
(+10.72%)Baseline: 286.51 ops/s
229.92 ops/s
(72.48%)
com.apurebase.kgraphql.QueryBenchmark.nestedObject📈 view plot
🚷 view threshold
7,416.46 ops/s
(-0.55%)Baseline: 7,457.76 ops/s
6,243.70 ops/s
(84.19%)
com.apurebase.kgraphql.RequestCachingBenchmark.invalidRequest📈 view plot
🚷 view threshold
🚨 view alert (🔔)
137,382.70 ops/s
(-38.63%)Baseline: 223,853.43 ops/s
193,875.71 ops/s
(141.12%)

com.apurebase.kgraphql.RequestCachingBenchmark.largeRequest📈 view plot
🚷 view threshold
7,622.60 ops/s
(-1.21%)Baseline: 7,715.93 ops/s
6,474.52 ops/s
(84.94%)
com.apurebase.kgraphql.RequestCachingBenchmark.smallRequest📈 view plot
🚷 view threshold
10,576.52 ops/s
(-6.36%)Baseline: 11,295.45 ops/s
9,083.57 ops/s
(85.88%)
com.apurebase.kgraphql.SimpleExecutionOverheadBenchmark.benchmark📈 view plot
🚷 view threshold
459,890.66 ops/s
(-2.49%)Baseline: 471,616.50 ops/s
452,606.43 ops/s
(98.42%)
🐰 View full continuous benchmarking report in Bencher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant