WIP ✨ PostgreSQL support#1191
Draft
aaronleopold wants to merge 21 commits into
Draft
Conversation
When performing migrations when connected to psql, the container failed to start with error returned from database: column \"completed_at\" is of type timestamp without time zone but expression is of type text". This commit changes the init migraitons to use .timestamp_with_time_zone() instead of .date_time()
This reverts commit e4c3ed4.
|
I can come back to this and make some contributions next week. I was mostly just exploring if I could easily plug in a psql connection setup but found that it required some changes to existing queries. Agree that it would make sense to heavily vet and add testing as I was really in an exploration phase of seeing if I could make it work. Then I stepped away the last week and a half for vacation 😅 Changes to the dockerfile can be reverted entirely (related to the github workflow changes already reverted). I was making attempts to improve the image build time, but no real improvement was made there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR piggybacks off of the work done by another (I became aware from #1167, thank you @sbeckstrand for your work) to add PostgreSQL support. There are a few seemingly unrelated changes in the mix, e.g. cargo chef in the Docker build, that on the surface seem fine but I have yet to meaningfully review. I may wind up pruning to keep this a more focused change, but we'll see.
I'm opening this PR a bit early in the hopes to get better visibility and help seeing it to the finish line. There are quite a few assurances I'd want via testing suites before really seriously considering a merge, since my immediate priority is ensuring existing or future SQLite-based installs do not break.
If you have time to help validate and/or improve, please feel free to base PRs into this branch.