Skip to content

feat: Add Modal recipe with storybook components#169

Closed
alexgrozav wants to merge 2 commits intomainfrom
alexgrozav/modal-recipes
Closed

feat: Add Modal recipe with storybook components#169
alexgrozav wants to merge 2 commits intomainfrom
alexgrozav/modal-recipes

Conversation

@alexgrozav
Copy link
Copy Markdown
Contributor

@alexgrozav alexgrozav commented Apr 5, 2026

Summary

  • Add Modal component recipe system with five parts: modal container, overlay, header, body, and footer — each with color, size, and variant style variants
  • Add Storybook stories and Vue preview components for the Modal recipe
  • Fix card recipe border adjacency collapsing to use borderWidth: 0 instead of borderColor: transparent for cleaner rendering

Test plan

  • Verify modal recipe unit tests pass (vitest run in theme package)
  • Check Storybook modal stories render correctly with all variant combinations
  • Confirm card border collapsing still works correctly after the fix

@alexgrozav
feat: Add Modal recipe with storybook and fix card border collapsing
c24f41a 
Add Modal component recipe system (modal, overlay, header, body, footer)
with variants for color, size, and variant styles. Includes storybook
stories and Vue preview components. Fix card border adjacency collapsing
to use borderWidth instead of borderColor for cleaner rendering.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 5, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: c16aa40

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 5, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app-styleframe-dev-production Ready Ready Preview, Comment Apr 5, 2026 4:15am
styleframe-dev-production Ready Ready Preview, Comment Apr 5, 2026 4:15am
styleframe-storybook Ready Ready Preview, Comment Apr 5, 2026 4:15am

Request Review

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2026

Codecov Report

❌ Patch coverage is 99.88386% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
theme/src/recipes/index.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@alexgrozav alexgrozav closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alexgrozav