Trim helper text for navigating and add leaked shortcut and UI trimming#50
Merged
Conversation
…rl+P/N to help, and clarify summary key label
- (selected + margin + 1).saturating_sub(visible) at all three scroll sites (browse, grouped, watch): the margin branch can fire while selected < visible, where the previous form underflowed usize and panicked in debug builds - clamp grouped/watch scroll offsets to list end the way adjust_scroll already does, so the margin cannot leave blank rows at the bottom - collapse the Ctrl+L if-let per clippy::collapsible_match and return after switching to Preview, matching the Esc handler above it - cargo fmt over the touched regions; add scroll-margin regression tests Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
|
Thanks @soomtong — the margin-on-scroll and the leak fixes are keepers, and the wrap-around summary cycle matches what the help screen always implied. I pushed one fixup commit (d623f0c) to your branch so this can land as-is:
Will merge once CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will improve some of the text in the screen and adjust the margin when the list navigation cursor moves to the bottom.