Skip to content

Improve efficiency of array manipulation in multicall.ts in eth_call promises #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aspnxdd wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improve efficiency of array manipulation in multicall.ts in eth_call promises #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25f3592
feat: improve efficiency array in multicall
aspnxdd Jun 17, 2026
b8bb3e7
feat: add bench
aspnxdd Jun 17, 2026
3ada8e8
feat: add rush change file
aspnxdd Jun 17, 2026
0de6952
feat: simplify bench js file
aspnxdd Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...anges/@subsquid/evm-typegen/feat-improve-efficiency-array-multicall_2026-06-17-21-37.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@subsquid/evm-typegen",
"comment": "improve efficiency of array manipulation in multicall eth_calls promises",
"type": "patch"
}
],
"packageName": "@subsquid/evm-typegen"
}
101 changes: 101 additions & 0 deletions evm/evm-typegen/bench/multicall-loop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
const { performance } = require("node:perf_hooks");

function splitSlice(maxSize, beg, end = Number.MAX_SAFE_INTEGER) {
maxSize = Math.max(1, maxSize);
const slices = [];
while (beg < end) {
const left = end - beg;
const splits = Math.ceil(left / maxSize);
const step = Math.round(left / splits);
slices.push([beg, beg + step]);
beg += step;
}
return slices;
}

function splitArray(maxSize, arr) {
if (arr.length <= maxSize) {
return [arr];
}

const pages = [];
for (const [beg, end] of splitSlice(maxSize, 0, arr.length)) {
pages.push(arr.slice(beg, end));
}
return pages;
}

async function oldPattern(calls, pageSize) {
const pages = splitArray(pageSize, calls);
const results = await Promise.all(
pages.map(async (page) => page.map((x) => x + 1)),
);
return results.flat();
}

async function newPattern(calls, pageSize) {
const promises = [];
for (const page of splitArray(pageSize, calls)) {
promises.push(Promise.resolve(page.map((x) => x + 1)));
}

const result = [];
for (const group of await Promise.all(promises)) {
result.push(...group);
}
return result;
}

async function bench(name, fn, calls, pageSize, rounds) {
for (let i = 0; i < 20; i++) {
await fn(calls, pageSize);
}

const start = performance.now();
let checksum = 0;
for (let i = 0; i < rounds; i++) {
const result = await fn(calls, pageSize);
checksum += result.length + result[0] + result[result.length - 1];
}
const ms = performance.now() - start;

return { name, ms, checksum };
}

async function run(size, pageSize, rounds) {
const calls = Array.from({ length: size }, (_, i) => i);
const oldResult = await bench("old", oldPattern, calls, pageSize, rounds);
const newResult = await bench("new", newPattern, calls, pageSize, rounds);

return {
size,
pageSize,
rounds,
oldMs: oldResult.ms,
newMs: newResult.ms,
speedup: oldResult.ms / newResult.ms,
same: oldResult.checksum === newResult.checksum,
};
}

async function main() {
const cases = [
{ size: 1000, pageSize: 50, rounds: 5000 },
{ size: 10000, pageSize: 100, rounds: 1000 },
];

for (const testCase of cases) {
console.log(
JSON.stringify(
await run(testCase.size, testCase.pageSize, testCase.rounds),
null,
2,
),
);
}
}

main().catch((err) => {
console.error(err);
process.exit(1);
});
66 changes: 38 additions & 28 deletions evm/evm-typegen/src/multicall.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,20 @@ export class Multicall extends ContractBase {
let [calls, pageSize] = this.makeCalls(args)
if (calls.length === 0) return []

const pages = Array.from(splitArray(pageSize, calls))
const results = await Promise.all(
pages.map(async (page) => {
const {returnData} = await this.eth_call(aggregate, {calls: page})
return returnData.map((data, i) => page[i].func.decodeResult(data))
}),
)
const promises: Promise<FunctionReturn<AnyFunc>[]>[] = []
for (let page of splitArray(pageSize, calls)) {
promises.push(
this.eth_call(aggregate, {calls: page}).then(({returnData}) => {
return returnData.map((data, i) => page[i].func.decodeResult(data))
}),
)
}

return results.flat()
const result: FunctionReturn<AnyFunc>[] = []
for (let group of await Promise.all(promises)) {
result.push(...group)
}
return result
}

tryAggregate<TF extends AnyFunc>(
Expand All @@ -97,31 +102,36 @@ export class Multicall extends ContractBase {
let [calls, pageSize] = this.makeCalls(args)
if (calls.length === 0) return []

const pages = Array.from(splitArray(pageSize, calls))
const results = await Promise.all(
pages.map(async (page) => {
const response = await this.eth_call(tryAggregate, {
const promises: Promise<MulticallResult<AnyFunc>[]>[] = []
for (let page of splitArray(pageSize, calls)) {
promises.push(
this.eth_call(tryAggregate, {
requireSuccess: false,
calls: page,
})
return response.map((res, i) => {
if (res.success) {
try {
return {
success: true,
value: page[i].func.decodeResult(res.returnData),
}).then((response) => {
return response.map((res, i) => {
if (res.success) {
try {
return {
success: true,
value: page[i].func.decodeResult(res.returnData),
}
} catch (err: any) {
return {success: false, returnData: res.returnData}
}
} catch (err: any) {
return {success: false, returnData: res.returnData}
} else {
return {success: false}
}
} else {
return {success: false}
}
})
}),
)
})
}),
)
}

return results.flat()
const result: MulticallResult<AnyFunc>[] = []
for (let group of await Promise.all(promises)) {
result.push(...group)
}
return result
}

private makeCalls(args: any[]): [calls: Call[], page: number] {
Expand Down
66 changes: 38 additions & 28 deletions test/erc20-transfers/src/abi/multicall.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,20 @@ export class Multicall extends ContractBase {
let [calls, pageSize] = this.makeCalls(args)
if (calls.length === 0) return []

const pages = Array.from(splitArray(pageSize, calls))
const results = await Promise.all(
pages.map(async (page) => {
const {returnData} = await this.eth_call(aggregate, {calls: page})
return returnData.map((data, i) => page[i].func.decodeResult(data))
}),
)
const promises: Promise<FunctionReturn<AnyFunc>[]>[] = []
for (let page of splitArray(pageSize, calls)) {
promises.push(
this.eth_call(aggregate, {calls: page}).then(({returnData}) => {
return returnData.map((data, i) => page[i].func.decodeResult(data))
}),
)
}

return results.flat()
const result: FunctionReturn<AnyFunc>[] = []
for (let group of await Promise.all(promises)) {
result.push(...group)
}
return result
}

tryAggregate<TF extends AnyFunc>(
Expand All @@ -97,31 +102,36 @@ export class Multicall extends ContractBase {
let [calls, pageSize] = this.makeCalls(args)
if (calls.length === 0) return []

const pages = Array.from(splitArray(pageSize, calls))
const results = await Promise.all(
pages.map(async (page) => {
const response = await this.eth_call(tryAggregate, {
const promises: Promise<MulticallResult<AnyFunc>[]>[] = []
for (let page of splitArray(pageSize, calls)) {
promises.push(
this.eth_call(tryAggregate, {
requireSuccess: false,
calls: page,
})
return response.map((res, i) => {
if (res.success) {
try {
return {
success: true,
value: page[i].func.decodeResult(res.returnData),
}).then((response) => {
return response.map((res, i) => {
if (res.success) {
try {
return {
success: true,
value: page[i].func.decodeResult(res.returnData),
}
} catch (err: any) {
return {success: false, returnData: res.returnData}
}
} catch (err: any) {
return {success: false, returnData: res.returnData}
} else {
return {success: false}
}
} else {
return {success: false}
}
})
}),
)
})
}),
)
}

return results.flat()
const result: MulticallResult<AnyFunc>[] = []
for (let group of await Promise.all(promises)) {
result.push(...group)
}
return result
}

private makeCalls(args: any[]): [calls: Call[], page: number] {
Expand Down