Fix Activity initialization order to prevent docById ReferenceError#508
Open
the-shreyash wants to merge 1 commit intosugarlabs:masterfrom
Open
Fix Activity initialization order to prevent docById ReferenceError#508the-shreyash wants to merge 1 commit intosugarlabs:masterfrom
the-shreyash wants to merge 1 commit intosugarlabs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ReferenceError: docById is not defined during Activity initialization.
Root Cause
Activity was instantiated before AMD dependencies (including utils/utils, where docById is defined) were fully loaded.
The line:
const activity = new Activity();
was executed outside the define(MYDEFINES, ...) block, causing constructor execution before module initialization completed.
Fix
Moved new Activity() inside the define(MYDEFINES, ...) callback to ensure proper dependency loading before constructor execution.
Result
Eliminates docById ReferenceError
Ensures correct AMD module lifecycle
Prevents early execution during initialization
Closes #507