🐛(frontend) add actions menu on mobile My Files page#657
Open
PanchoutNathan wants to merge 3 commits intomainfrom
Open
🐛(frontend) add actions menu on mobile My Files page#657PanchoutNathan wants to merge 3 commits intomainfrom
PanchoutNathan wants to merge 3 commits intomainfrom
Conversation
The more_vert button was only shown inside folders on mobile. This adds a dropdown with create folder and import options on the My Files default route. Also adds includeCreate option to useCreateMenuItems to allow excluding document creation items.
Test that My Files shows the more menu with create folder and import options on mobile viewport. Test that the more menu button is visible inside a folder on mobile viewport.
Swap SVG imports and material-icons spans for dedicated ui-kit icon components (Shared, Download, Copy, Star, Edit, ArrowRight, Info, Trash, etc). Add dropdown menu icon sizing style.
|
NathanVss
approved these changes
Apr 15, 2026
Contributor
NathanVss
left a comment
NathanVss
left a comment
There was a problem hiding this comment.
LGTM, please see the comment about icon size
Comment on lines
+112
to
+115
| .c__dropdown-menu-item__icon { | ||
| width: 20px; | ||
| height: 20px; | ||
| } |
Contributor
There was a problem hiding this comment.
This hardcoded override is not needed, the Figma sketches are 24x24: https://www.figma.com/design/XDjWHDLIiNY4mtpyj21EVK/Drive?node-id=12066-24411&t=Rrmt2DvJtCAgXwkq-0
You can use IconSize.MEDIUM sized icons.
NathanVss
reviewed
Apr 15, 2026
| {t(defaultRouteData.label)} | ||
| {t(defaultRouteData.label)} | ||
| </div> | ||
| {defaultRouteId === DefaultRoute.MY_FILES && ( |
Contributor
There was a problem hiding this comment.
It is a dependency inversion pattern here. The consumer of this component should tell him what to display, not the opposite.
I think we can live with that at this small scale .. but not huge fan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
My Files page with "New folder", "Import files" and
"Import folders" options
includeCreateoption touseCreateMenuItemshook to allow excluding document creation items
in action menu items