🐛(front) show actual selection count in hard delete modal#665
Merged
PanchoutNathan merged 1 commit intomainfrom Apr 16, 2026
Merged
🐛(front) show actual selection count in hard delete modal#665PanchoutNathan merged 1 commit intomainfrom
PanchoutNathan merged 1 commit intomainfrom
Conversation
NathanVss
approved these changes
Apr 15, 2026
The trash hard delete confirmation modal always displayed "2 items" regardless of how many items were selected, because it received a boolean `multiple` prop and hardcoded `count: 2` for the i18n interpolation. Replace the boolean with the real selection length so the plural message reflects the actual count.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
regardless of the selection size, because the modal received a
boolean
multipleprop and hardcodedcount: 2for the i18ninterpolation.
multipleboolean with acountnumber prop and passselectedItems.lengthfrom the trash page so the plural messagereflects the real selection.
Closes #651
Test plan
confirm the modal reads "delete these 3 items forever?".
"delete this item forever?".