forked from forkcms/forkcms
-
Notifications
You must be signed in to change notification settings - Fork 3
551 ramsey UUID en ramsey UUID doctrine #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ilaria-orlando
merged 6 commits into
master
from
551-ramsey-uuid-en-ramsey-uuid-doctrine
Mar 23, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5a0f756
Remove ramsey/uuid and require symfony/uuid
941d09d
Add uuid dbal type and use it in doctrine configs
da24df8
Remove all ramsey uuid use statements and use symfony uuid instead
3318ed2
Lock version
69d9081
merge master into 551-ramsey-uuid-en-ramsey-uuid-doctrine
1f97f21
Remove uuid generator
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| <?php | ||
|
|
||
| namespace Common\Doctrine\Type; | ||
|
|
||
| use Doctrine\DBAL\Platforms\AbstractPlatform; | ||
| use Doctrine\DBAL\Types\GuidType; | ||
| use Doctrine\DBAL\Types\ConversionException; | ||
| use Throwable; | ||
| use Symfony\Component\Uid\Uuid; | ||
|
|
||
| final class UuidType extends GuidType | ||
| { | ||
| public const NAME = 'uuid'; | ||
|
|
||
| public function convertToPHPValue($value, AbstractPlatform $platform): ?Uuid | ||
| { | ||
| if ($value instanceof Uuid) { | ||
| return $value; | ||
| } | ||
|
|
||
| if (!is_string($value) || $value === '') { | ||
| return null; | ||
| } | ||
|
|
||
| try { | ||
| return Uuid::fromString($value); | ||
| } catch (Throwable) { | ||
| throw ConversionException::conversionFailed($value, self::NAME); | ||
| } | ||
| } | ||
|
|
||
| public function convertToDatabaseValue($value, AbstractPlatform $platform): ?string | ||
| { | ||
| if ($value === null || $value === '') { | ||
| return null; | ||
| } | ||
|
|
||
| if ($value instanceof Uuid) { | ||
| return $value->toRfc4122(); | ||
| } | ||
|
|
||
| if (is_string($value) || (is_object($value) && method_exists($value, '__toString'))) { | ||
| $string = (string) $value; | ||
|
|
||
| if ($string !== '' && Uuid::isValid($string)) { | ||
| return $string; | ||
| } | ||
| } | ||
|
|
||
| throw ConversionException::conversionFailed($value, self::NAME); | ||
| } | ||
|
|
||
| public function getName(): string | ||
| { | ||
| return self::NAME; | ||
| } | ||
|
|
||
| public function requiresSQLCommentHint(AbstractPlatform $platform): bool | ||
| { | ||
| return true; | ||
| } | ||
|
|
||
| /** @return string[] */ | ||
| public function getMappedDatabaseTypes(AbstractPlatform $platform): array | ||
| { | ||
| return [self::NAME]; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): Treating empty-string values as null in convertToDatabaseValue may mask invalid inputs.
Because
convertToDatabaseValuemaps bothnulland''tonull, an empty string ID from the application will be stored asNULLinstead of failing conversion. This can hide invalid input and violate NOT NULL expectations. Consider only treatingnullasnulland letting''go through normal validation so it raises aConversionExceptionif it’s not a valid UUID.