feat: refactor into flat structure #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matoous
force-pushed
the
md/flat-structure
branch
from
074f76b to
a2bcada
Compare
Package names such as `shared` are non-idiomatic for Go and there's no way for us to move them under the root `sumup` package without running into circular dependency issues. Refactor the SDK to have a flat structure with clients defined in the root `sumup` package. This makes it easier to ensure we don't have duplicate definitions of schemas where one will do. The method calls are still nice with e.g. `client.Checkouts.Create(...)` but we no longer need the awkward `shared.Currency` and instead can use nicer `sumup.Currency` which avoids import collisions for users of this SDK.
matoous
force-pushed
the
md/flat-structure
branch
from
a2bcada to
b19e1bd
Compare
julienschmidt
approved these changes
Jan 26, 2026
matoous
force-pushed
the
md/flat-structure
branch
2 times, most recently
from
8c42856 to
5a75c15
Compare
matoous
force-pushed
the
md/flat-structure
branch
from
5a75c15 to
d0a6048
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package names such as
sharedare non-idiomatic for Go and there's no way for us to move them under the rootsumuppackage without running into circular dependency issues. Refactor the SDK to have a flat structure with clients defined in the rootsumuppackage. This makes it easier to ensure we don't have duplicate definitions of schemas where one will do. The method calls are still nice with e.g.client.Checkouts.Create(...)but we no longer need the awkwardshared.Currencyand instead can use nicersumup.Currencywhich avoids import collisions for users of this SDK.