fix compilation with new new nightly VaList#165
Conversation
|
My bad, the rust version was off by 1 day. |
|
Sigh. My apologies. I was just running Unfortunately, I have to do something else for now. I will fix this later today. |
In 2025-12-05, a Rust pull request at rust-lang/rust#141980 reworked the `VaList` implementation to be abi-compatible with C. This broke: * the `printf-compat` implementation, which is fixed in version 0.3 * pretty much every function that methods of `VaList` (most commonly `as_va_list`), since they no longer exist Here, we fix both of those problems and update the compiler version in `rust-toolchain.toml` to be the oldest compiler that will already have this new implementation. Updating the compiler has created 2 unforseen problems: 1. When unwinding, the new Rust version now prints the process's PID. This means for the `c-gull-unwinding` we can no longer use the `assert_cmd` API, as it does not expose the child PID to us. 2. The `c-gull/src/nss.rs` had 3 extra warnings of operations whose results were unused. This was also breaking some other tests. Both of these were also fixed.
|
Third time's the charm??? In any case, I've now fixed what I believe to be every function that was using Beside that, as I explain in the commit message, updating the compiler version created 2 unforseen problems:
It seems I underestimated how much work this was. Hopefully it won't fail miserably at literally the very first check this time 😅 |
|
This looks good. Thanks! |
In 2025-12-05, a Rust pull request at rust-lang/rust#141980 reworked the
VaListimplementation to be abi-compatible with C. This broke:printf-compatimplementation, which is fixed in version 0.3fcntlfunctions, because they calledas_va_list, and that function no longer existsHere, we fix both of those problems and update the compiler version in
rust-toolchain.tomlto be the oldest compiler that will already have this new implementation.Fixes #164