Convert api to server actions#28
Merged
Merged
Conversation
WillSewell
marked this pull request as ready for review
January 9, 2026 17:11
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
WillSewell
force-pushed
the
01-09-convert_api_to_server_actions
branch
2 times, most recently
from
January 9, 2026 17:21
5fefa8b to
629007c
Compare
cxkoda
reviewed
Jan 9, 2026
| const session = await getSession(); | ||
|
|
||
| if (!session) { | ||
| return { error: "Unauthorized" }; |
Contributor
There was a problem hiding this comment.
we can just throw in server functions, which will make the return types simpler
cxkoda
reviewed
Jan 9, 2026
Comment on lines
+69
to
+71
| export type ServerActionResult<T> = | ||
| | { success: true; data: T } | ||
| | { success: false; error: string; unauthorized?: boolean }; |
Contributor
There was a problem hiding this comment.
related to my comment above, I'd probably just throw in server functions, which reduces allows us to reduce the result type to just T
Collaborator
Author
There was a problem hiding this comment.
Ah yeah, much nicer
WillSewell
changed the base branch from
will-backend-token-tx-polish
to
graphite-base/28
January 9, 2026 19:44
WillSewell
force-pushed
the
01-09-convert_api_to_server_actions
branch
from
January 9, 2026 19:44
629007c to
8ef46fe
Compare
WillSewell
force-pushed
the
01-09-convert_api_to_server_actions
branch
from
January 9, 2026 19:44
8ef46fe to
127516e
Compare
cxkoda
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.