Run lint in CI and fix issues with vscode extension#8
Merged
Conversation
eslint was erroring when run via the vscode extension, but not via the CLI. Didn't look too deeply into it the root cause suggests it's an issue with eslint and pnpm. I've added the suggested incantation to publicHoistPattern and it seems to work now, so I'm not asking anymore questions...
It was previously failing to build in CI because the initial render happens on the server, where `window` is not defiend.
cxkoda
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eslint was erroring when run via the vscode extension, but not via the CLI.
Didn't look too deeply into it the root cause suggests it's an issue with eslint and pnpm. I've added the suggested incantation to publicHoistPattern and it seems to work now, so I'm not asking anymore questions...