Skip to content

Fix Android support configuration to avoid ClassNotFoundException #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nabiltntn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Android support configuration to avoid ClassNotFoundException #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
<platform name="android">
<config-file target="res/xml/config.xml" parent="/*">
<feature name="applicationPreferences">
<param name="android-package" value="com.appgiraffe.plugins.applicationPreferences"/>
<!-- android-package value should contain fully qualified class name -->
<param name="android-package" value="com.appgiraffe.plugins.applicationPreferences.applicationPreferences"/>
</feature>
</config-file>
<source-file src="src/android/applicationPreferences.java" target-dir="src/com/appgiraffe/plugins/applicationPreferences" />
Expand Down
7 changes: 5 additions & 2 deletions src/android/applicationPreferences.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ public boolean execute(String action, JSONArray args,
} else if (action.equals("set")) {
String key = args.getString(0);
String value = args.getString(1);
if (sharedPrefs.contains(key)) {
//we should avoid this condition because it doesnt allow adding new <key,value>
//if (sharedPrefs.contains(key)) {
Editor editor = sharedPrefs.edit();
if ("true".equals(value.toLowerCase()) || "false".equals(value.toLowerCase())) {
editor.putBoolean(key, Boolean.parseBoolean(value));
Expand All @@ -54,10 +55,12 @@ public boolean execute(String action, JSONArray args,
editor.commit();
callbackContext.success();
return true;
} else {
/*
} else {
callbackContext.error("No such property called " + key);
return false;
}
*/
} else if (action.equals("load")) {
JSONObject obj = new JSONObject();
Map<String,?> prefs = sharedPrefs.getAll();
Expand Down