fix(cli): redact API keys#5891
Open
7ttp wants to merge 1 commit into
Open
Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
fixes project keys being written to CLI traces, matching the Go cli's behavior...
Problem
The Go-cli use to send keys through the
apikeyheader:cli/apps/cli-go/pkg/fetcher/gateway.go
Lines 22 to 33 in 2cb2d6e
Its debug transport only logs the request method and URL:
cli/apps/cli-go/internal/debug/http.go
Lines 14 to 16 in 2cb2d6e
Effect tracing captures request headers, but
apikeyis not included in its default redaction list...this allowed values to be written to local traces...
sol
exclude
apikeyheader attributes at the tracing boundary....requests and all other telemetry remain unchanged, while NDJSON and debug output no longer contain project keys....
ref: