feat: Persist destination write stream state#874
Open
1neoneo3 wants to merge 1 commit into
Open
Conversation
fc12b4a to
be5d594
Compare
be5d594 to
494b203
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 494b203d33
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cec3718 to
9bde359
Compare
Author
9bde359 to
e273987
Compare
Contributor
|
Thanks for the PR! We are currently thinking internally on how we want to add arbitrary metadata for destinations to store. Since it's hard to predict what each destination will need, we were thinking of going towards a design where any destination can store arbitrary data into the store. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds durable destination write stream state to the replication store.
This PR introduces a small store-level foundation that lets a destination persist the state of an external write stream, including:
The implementation is wired through:
destination_write_streamstableWhy
BigQuery Storage Write API committed streams need a stable stream name and durable offsets to make retries safe.
Without persisted offsets, a destination can append the same logical rows again after a retry or process restart. This state store is the foundation needed by #875 to use BigQuery committed streams safely for append-only history writes.
Relationship to the follow-up PR
This is the first PR in the split for #873.
Keeping this as a separate PR makes the storage contract reviewable without the larger BigQuery append-only implementation in the same diff.
Behavior and compatibility
Tests
cargo check -p etl --features test-utilscargo check -p etl-replicator --no-default-featurescargo test -p etl --features test-utils reset_for_resync_clears_destination_write_stream_state --test mainRefs #873