Skip to content

fix: upload large images/resize images in headers/footers#3319

Open
VladaHarbour wants to merge 1 commit into
mainfrom
sd-3067-3149_header-images
Open

fix: upload large images/resize images in headers/footers#3319
VladaHarbour wants to merge 1 commit into
mainfrom
sd-3067-3149_header-images

Conversation

@VladaHarbour
Copy link
Copy Markdown
Contributor

No description provided.

@VladaHarbour VladaHarbour self-assigned this May 15, 2026
@VladaHarbour VladaHarbour requested a review from a team as a code owner May 15, 2026 13:10
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 15, 2026

SD-3067

@github-actions
Copy link
Copy Markdown
Contributor

Status: PASS

The two changed files only deal with the image relationship plumbing for header/footer parts. I verified the OOXML constructs they touch:

  • The new IMAGE_REL_TYPE = 'http://schemas.openxmlformats.org/officeDocument/2006/relationships/image' constant matches the canonical OPC relationship type for image parts (ECMA-376 Part 1 §15.2.x), and it's just hoisted from the inline literal already used in addImageRelationshipForId. No semantic change to the emitted <Relationship> element.
  • The <Relationship> element written by addImageRelationshipForId keeps the same required attributes (Id, Type, Target) — no TargetMode (correct, since image parts are internal).
  • The header/footer reuse path in translateImageNode only reads params.existingRelationships and copies rel.attributes.Id into a:blip/@r:embed. That's the spec-correct way to reference an internal image part from DrawingML (§20.1.8.13 a:blip).
  • The test's fixture relationship (Id: rIdHeaderImage, Type: …/relationships/image, Target: media/test.png) is a valid header-part-local rel: the target is resolved relative to word/_rels/header1.xml.rels, which is consistent with how the rest of the PR writes header/footer rels.

No non-existent attributes, no missing required ones, and the default-value semantics are unchanged from the prior code path. See https://ooxml.dev/spec?q=blip and https://ooxml.dev/spec?q=Relationship if you want to cross-reference.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ccfb3cfc7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/super-editor/src/editors/v1/core/parts/adapters/header-footer-sync.ts Outdated
Comment thread packages/super-editor/src/editors/v1/core/super-converter/SuperConverter.js Outdated
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants