Skip to content

πŸ”„ Sync stable β†’ main (conflicts)#3332

Open
superdoc-bot[bot] wants to merge 1 commit into
mainfrom
sync/stable-to-main-20260515-212350
Open

πŸ”„ Sync stable β†’ main (conflicts)#3332
superdoc-bot[bot] wants to merge 1 commit into
mainfrom
sync/stable-to-main-20260515-212350

Conversation

@superdoc-bot
Copy link
Copy Markdown
Contributor

@superdoc-bot superdoc-bot Bot commented May 15, 2026

Summary

Merges latest stable patches into main. Has merge conflicts that need manual resolution.

Release artifact conflicts were auto-resolved, but other conflicts remain.


Auto-created by sync-patches workflow.

@superdoc-bot superdoc-bot Bot requested a review from a team as a code owner May 15, 2026 21:23
@superdoc-bot superdoc-bot Bot added patch-sync Patch sync from release branch review: careful review: thorough and removed review: careful labels May 15, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1607257a9a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

if git merge --no-ff --no-edit "origin/${SOURCE_BRANCH}"; then
MERGE_STATUS="clean"
else
<<<<<<< HEAD
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Clean merge markers from promote-stable merge script

The workflow commit leaves Git conflict markers in the shell block, so when promote-stable.yml runs it will execute lines like <<<<<<< HEAD/=======/>>>>>>> origin/stable as shell input and fail before setting MERGE_STATUS. This breaks the stable→main promotion automation for every run of this workflow until the conflict is resolved.

Useful? React with πŸ‘Β / πŸ‘Ž.

Comment on lines +44 to +48
<<<<<<< HEAD
({ commands, state }) => {
=======
({ commands, state, tr, dispatch }) => {
>>>>>>> origin/stable
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Remove unresolved conflict markers from text-align extension

This file contains unresolved merge markers inside setTextAlign, which makes the JavaScript invalid and prevents the editor package from parsing/building. Any runtime or test path that imports this extension will fail immediately with a syntax error until the conflict markers are removed and one implementation is selected.

Useful? React with πŸ‘Β / πŸ‘Ž.

Comment on lines +721 to 723
<<<<<<< HEAD
}
};
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Resolve merge markers left in comments store source

Unresolved conflict markers were committed into comments-store.js, which makes the module syntactically invalid and breaks loading/building the SuperDoc package paths that import this store. This is a hard failure, not a behavior edge case, and must be resolved for the package to run.

Useful? React with πŸ‘Β / πŸ‘Ž.

Comment on lines +13 to +17
<<<<<<< HEAD
type ContentControlsHandle,
type ContentControlsSlice,
=======
>>>>>>> origin/stable
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove conflict markers from exported UI type declarations

The public ui.d.ts barrel includes raw merge markers around exported types, which makes the declaration file invalid TypeScript syntax. Consumers importing superdoc/ui types (and local type-checking for this package) will fail until this conflict is resolved.

Useful? React with πŸ‘Β / πŸ‘Ž.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch-sync Patch sync from release branch review: thorough

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants