SD-2663 - feature: support table of contents hovering#3333
Conversation
superdoc-bot
Bot
added
review: thorough
review: careful
and removed
review: thorough
labels
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4544d0019d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const pendingTocLink = this.#pendingTocLinkNav; | ||
| this.#pendingTocLinkNav = null; | ||
| if (pendingTocLink && !this.#dragThresholdExceeded) { | ||
| this.#handleLinkClick(event, pendingTocLink); |
There was a problem hiding this comment.
The deferred TOC path always calls #handleLinkClick on pointerup when #dragThresholdExceeded is false, but it never verifies that the pointer was released on the same TOC link (or even inside it). Because this handler stores the link from pointerdown, a user can press on a TOC entry, move off the link, and still trigger goToAnchor on release, which removes the expected ability to cancel the action by releasing elsewhere.
Useful? React with 👍 / 👎.
3 participants
Introducing a new hover state for TOCs. Like MS Word does, when you hover in a TOC, we provide a visual feedback to the user with a grey background.