Conversation
|
@neilco 👍 can we get this merged? it seems like a pretty safe addition, I have the same use-case |
|
@supermarin I'd like to review this but I don't have push access to the |
|
@neilco I thought you've had full push access on this one :) let me double check |
|
yep, confirming |
|
@supermarin It seems to working now. Must have been a glitch in The Matrix. |
neilco
left a comment
neilco
left a comment
There was a problem hiding this comment.
@marcpalmer You've committed a user-specific file that will need to be removed before merging.
Also, if you could add targets for watchOS, tvOS, and macOS, that you would be greatly appreciated.
| isa = PBXProject; | ||
| attributes = { | ||
| LastUpgradeCheck = 0700; | ||
| ORGANIZATIONNAME = supermarin; |
There was a problem hiding this comment.
Please change this to supermar.in
| INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 8.0; | ||
| LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks"; | ||
| PRODUCT_BUNDLE_IDENTIFIER = supermarin.ObjectiveSugar; |
There was a problem hiding this comment.
Please change this to in.supermar.ObjectiveSugar
| INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 8.0; | ||
| LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks"; | ||
| PRODUCT_BUNDLE_IDENTIFIER = supermarin.ObjectiveSugar; |
There was a problem hiding this comment.
This also needs changing to in.supermar.ObjectiveSugar
| buildSettings = { | ||
| INFOPLIST_FILE = ObjectiveSugarTests/Info.plist; | ||
| LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks"; | ||
| PRODUCT_BUNDLE_IDENTIFIER = supermarin.ObjectiveSugarTests; |
There was a problem hiding this comment.
Please change this to in.supermar.ObjectiveSugarTests
| buildSettings = { | ||
| INFOPLIST_FILE = ObjectiveSugarTests/Info.plist; | ||
| LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks"; | ||
| PRODUCT_BUNDLE_IDENTIFIER = supermarin.ObjectiveSugarTests; |
There was a problem hiding this comment.
This also needs changing to in.supermar.ObjectiveSugarTests
|
@marcpalmer Could you structure the project similar to the what's in the Example folder? It would be good to get the tests into the project. |
|
For the user specific file you can add an entry to the https://github.com/github/gitignore/blob/master/Objective-C.gitignore You can just add that file to the root of the repo as |
|
Or you could just copy the |
4 participants
Cocoapods started causing me problems so I'm trying out Carthage. To make projects work with Carthage you don't have a podspec, you just create an Xcode project with a shared scheme that builds a dynamic framework (iOS 8 only).
You might want to move some of the files around, but you need to make sure xcodebuild will still build it. I'm not sure but we might need another scheme to build the version for Mac..