This repository was archived by the owner on Dec 12, 2018. It is now read-only.
Added NSArray -sortWithBlock, -uniq, -indexOf and -partition#51
Open
gurgeous wants to merge 1 commit intosupermarin:masterfrom
gurgeous:sortWithBlock,uniq,indexOf,partition,compare
Open
Added NSArray -sortWithBlock, -uniq, -indexOf and -partition#51gurgeous wants to merge 1 commit intosupermarin:masterfrom gurgeous:sortWithBlock,uniq,indexOf,partition,compare
gurgeous wants to merge 1 commit intosupermarin:masterfrom
gurgeous:sortWithBlock,uniq,indexOf,partition,compare
Conversation
sortWithBlock also requires [NSArray compare:] to really be useful. Includes tests.
Contributor
Author
|
Just circling back on this one... Suggested improvements? Would this be easier if it were separate pull requests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just switched my project to use ObjectiveSugar and I want these too. I also added [NSArray compare:], which is pretty much required in order for sortWithBlock to work rationally. It's easy to implement and just a useful thing to have in general. Hopefully I did everything correctly. :)
If you like these and accept the pull request, I have more things I want to add...
One suggestion - would you consider revamping or getting rid of the examples in the README? It feels hard to maintain and error prone. Maybe something like this instead?
https://github.com/zdavison/NSString-Ruby
(see the Method List section)