Skip to content

revamp chrome extension#971

Open
ishaanxgupta wants to merge 6 commits into
mainfrom
ishaan/chrome_ext
Open

revamp chrome extension#971
ishaanxgupta wants to merge 6 commits into
mainfrom
ishaan/chrome_ext

Conversation

@ishaanxgupta
Copy link
Copy Markdown
Contributor

@ishaanxgupta ishaanxgupta commented May 19, 2026

extension works across chatgpt, gemini, claude. there is a live marker now with tool tip that shows supermemory is connected, the welcome msg is revamped fully.
The autocomplete works as expected.

here is a photo of the welcome page:
image

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 19, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 74edaac May 23 2026, 07:15 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 19, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 74edaac Commit Preview URL

Branch Preview URL
May 23 2026, 07:16 PM

- Remove dead code after return statements in chatgpt.ts and claude.ts
- Replace forEach callbacks that return values with for...of loops
- Prefix unused function with underscore (appendStoredMemories)
- Apply formatting fixes to all changed files

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ishaanxgupta ishaanxgupta marked this pull request as ready for review May 19, 2026 14:52
@graphite-app graphite-app Bot added the extension related to Supermemory Chrome Extension label May 19, 2026
@graphite-app graphite-app Bot requested a review from Dhravya May 19, 2026 14:52
@claude
Copy link
Copy Markdown

claude Bot commented May 19, 2026

Claude finished @ishaanxgupta's task in 1m 46s —— View job


PR Review Complete

  • Fetch PR diff and analyze changes
  • Check for bugs, security issues, and logic errors
  • Review existing review comments to avoid duplicates
  • Submit review findings

Overview: Adds Gemini support to the browser extension, introduces a Tab-to-accept memory suggestion UI, refactors platform-specific code to use shared components, and improves error handling in the popup.

Issues found:

  • Debug flags (CHATGPT_DEBUG, CLAUDE_DEBUG, GEMINI_DEBUG) are all hardcoded to true — will cause verbose console output in production (already noted in previous review, still not fixed)
  • Dead code: _appendStoredMemories function in gemini.ts:366 is defined but never used (already noted in previous review, still not fixed)

No new critical bugs, security vulnerabilities, or logic errors were identified. The implementation uses proper XSS prevention (all dynamic content uses textContent instead of innerHTML), has good error handling with fallback mechanisms in the popup, and maintains clean separation of concerns via the shared memory-suggestion.ts module.

Score: 9/10

Clean implementation with only minor housekeeping items remaining from the previous review. Once the debug flags are set to false and the dead code is removed, this is ready to ship.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds Gemini support to the browser extension, introduces a new memory suggestion UI with Tab-to-accept functionality, refactors platform-specific code to use shared components, and improves error handling in the popup.

Issues found:

  • Debug flags (CHATGPT_DEBUG, CLAUDE_DEBUG, GEMINI_DEBUG) are all hardcoded to true — will cause verbose console output in production
  • Dead code: _appendStoredMemories function in gemini.ts is defined but never used

The implementation is well-structured with proper error handling, no XSS vulnerabilities (all dynamic content uses textContent instead of innerHTML), and good separation of concerns via the shared memory-suggestion.ts module.

Score: 9/10

Clean implementation with only minor housekeeping items to address before shipping.

Comment thread apps/browser-extension/entrypoints/content/gemini.ts
Comment thread apps/browser-extension/entrypoints/content/gemini.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension related to Supermemory Chrome Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant