Improve quick note editor interactions & fix filter chips responsiveness#989
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-app | 229b828 | Commit Preview URL Branch Preview URL |
May 23 2026, 04:16 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-mcp | 229b828 | May 23 2026, 04:15 PM |
|
Claude finished @ishaanxgupta's task in 1m 17s —— View job Re-review complete
Summary: The double-save bug I flagged in the previous review has been fixed. The Score: 9/10 |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview: Adds an expandable quick note editor using TipTap and improves filter chips responsiveness on mobile.
Issues found:
- Potential double-save when pressing Cmd+Enter in the expanded editor (see inline comment)
Score: 8/10
The implementation is solid overall. The masonry key fix correctly handles mobile/desktop item differences, the filter chips layout changes are clean CSS, and the TextEditor refactor properly exposes placeholder and autoFocus props. The z-index bump for slash commands (50→120) correctly ensures they appear above the expanded modal (z-100).
One bug to fix: the onKeyDown handler on the expanded modal's motion.div duplicates the Cmd+Enter handling that TextEditor already does internally, which could cause onSave to fire twice.
There was a problem hiding this comment.
Overview: Adds an expandable quick note editor using TipTap and improves filter chips responsiveness on mobile.
Issues found: None — the double-save bug from the previous review has been fixed. The onKeyDown handler on the expanded modal has been removed, and Cmd+Enter is now handled solely through TextEditor's onSubmit prop.
Score: 9/10
The implementation is solid:
- Masonry key fix correctly handles mobile/desktop item differences by deriving from
masonryItemsinstead ofdocuments - Filter chips layout changes are clean responsive CSS with proper order swapping
- TextEditor refactor properly exposes
placeholderandautoFocusprops viacreateDefaultExtensions() - The z-index bump for slash commands (50→120) correctly ensures they appear above the expanded modal (z-100)
- Modal cleanup (body overflow, event listeners) is properly handled in the useEffect cleanup functions
Ready to ship.
2 participants
On phone, the filter chips now get their own horizontally scrollable row, so All, Notes, Tweets, Web Pages, and any future connection chips can fit without squeezing. The Grid / Timeline segmented control stays grouped on the next row and aligned to the right.
The QuickNoteCard now uses the same TipTap TextEditor as the full-screen note, so typing / should show the slash-command options like headings. It also expands from 120px to 188px when focused or when it has draft content, then collapses again on blur if empty.
I also updated TextEditor so it can be used inline safely: it now supports editable={false} while saving, and it syncs external content resets without constantly resetting the editor while typing.