Skip to content

fix timeline responsiveness#997

Merged
ishaanxgupta merged 5 commits into
mainfrom
ishaa/dev5
May 24, 2026
Merged

fix timeline responsiveness#997
ishaanxgupta merged 5 commits into
mainfrom
ishaa/dev5

Conversation

@ishaanxgupta
Copy link
Copy Markdown
Contributor

@ishaanxgupta ishaanxgupta commented May 24, 2026

image image

@claude
Copy link
Copy Markdown

claude Bot commented May 24, 2026

Claude finished @ishaanxgupta's task in 1m 12s —— View job


Review Complete

Overview: This PR improves timeline responsiveness with mobile-first CSS refactoring and adds smooth expand/collapse animations using Motion (Framer Motion v12).

Issues found: None — this looks good to ship.

Analysis:

The changes are purely presentational and well-implemented:

  • memories-grid.tsx: Responsive styling adjustments for the selection toolbar — smaller gaps/padding on mobile, hiding "selected" text on small screens. No logic changes.

  • timeline-view.tsx:

    • Mobile-responsive grid layout with proper grid-cols breakpoints for the new timeline indicator column
    • AnimatePresence + motion for smooth group expansion with staggered delays capped sensibly (Math.min(index * 0.025, 0.12))
    • New isLast prop correctly calculated as index === group.docs.length - 1 for border-radius styling
    • Animated timeline dot and line that highlights when periodHasExpandedGroup is true
    • The periodIndex === periodGroups.length - 1 check correctly hides the extended timeline line for the last period

All existing null checks on doc.id remain intact. The Motion import (from "motion/react") is correct for the project's Motion v12.26.2 dependency.

Score: 10/10


@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 24, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 9822483 May 24 2026, 08:35 AM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 24, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 9822483 Commit Preview URL

Branch Preview URL
May 24 2026, 08:36 AM

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: This PR improves timeline responsiveness with mobile-first CSS refactoring and adds smooth expand/collapse animations using Framer Motion.

Issues found: None — this looks good to ship.

The changes are purely presentational:

  • Mobile-responsive grid layout with proper column/row positioning
  • AnimatePresence + motion for smooth group expansion animations
  • New isLast prop for proper border-radius on the last item in collapsed groups
  • Animated timeline indicator (dot and line) that highlights when groups are expanded

All existing logic remains intact with proper null checks on doc.id. The staggered animation delays are capped sensibly (Math.min(index * 0.025, 0.12)), and the periodIndex === periodGroups.length - 1 check correctly hides the timeline line for the last period.

Score: 10/10

@ved015 ved015 closed this May 24, 2026
@ishaanxgupta ishaanxgupta reopened this May 24, 2026
@ishaanxgupta ishaanxgupta merged commit d30e53f into main May 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants