fix(iframe resizing): improve positioning of the iFrame after events#476
Merged
Conversation
The iFrame component has a natural scrollbar built into it. Currently, this is never seen because the upstream "resize" event broadcasts are handled without any delay. However, to fix a problem with transiant small heigh pages, the scrolling needs to be disabled to avoid showing a flash of scrollbar content.
Rodeoclash
changed the title
Rodeoclash
force-pushed
the
maint/remove-scroll
branch
from
b002480 to
7cfe3a8
Compare
braidonw
approved these changes
May 11, 2026
| ONBOARDING_SESSION_COMMITTED = "onboardingSessionCommitted", | ||
| ONBOARDING_STEP_CHANGED = "onboardingStepChanged", | ||
| ONBOARDING_SESSION_FINISHED = "onboardingSessionFinished", | ||
| PAGE_CHANGED = "pageChanged", |
Contributor
Author
There was a problem hiding this comment.
I've updated it to page loaded, was more specific about exactly what was happening.
This adds support for a new page changed event in the embed which will be fired when the page is changed in SuperAPI. This will handle automatically placing the iFrame into the browsers viewport in the correct location when navigating between pages.
Rodeoclash
force-pushed
the
maint/remove-scroll
branch
from
7cfe3a8 to
8147a7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iFrame component has a natural scrollbar built into it. Currently, this is never seen because the upstream "resize" event broadcasts are handled without any delay. However, to fix a problem with transiant small heigh pages, the scrolling needs to be disabled to avoid showing a flash of scrollbar content.