4.15.1

[yusuftor]

4.15.1

Enhancements

• Adds an onCustomCallback parameter to getPaywall.
• SuperwallOptions.localResources now accepts UIImage's from xcasset files, e.g. UIImage(named: "my-image").
• Exposes abandoned transaction product params in audience filters.

Fixes

• Sanitizes email user attribute.

Greptile Summary

This PR bumps the SDK to 4.15.1 with four changes: adds an onCustomCallback parameter to getPaywall (wired through a CustomCallbackRegistry and PaywallViewControllerDelegateAdapter); extends SuperwallOptions.localResources to accept UIImage values from asset catalogs via the new AssetResource protocol; exposes abandoned-transaction product attributes in audience filters; and sanitises the "email" user attribute against a regex-validated Email type before sending it to the server.

Confidence Score: 5/5

Safe to merge — no P0 or P1 issues found; all four feature areas are well-tested and correctly implemented.

The PR is clean with no new critical or warning-level defects. The case-sensitive email key match (switch key vs switch key.lowercased()) was already flagged in a prior review cycle and remains; all other logic is sound. The custom callback registration lifecycle (init → didSet → deinit) is correct, localResources is properly excluded from Encodable, and the NSCache<UIImage, NSData> usage is thread-safe.

Sources/SuperwallKit/Identity/UserAttributes.swift — case-sensitive email key match noted in previous review remains unresolved.

Important Files Changed

Filename	Overview
Sources/SuperwallKit/Identity/Email.swift	New Email value type with regex-based validation; uses \z anchor correctly to reject trailing newlines.
Sources/SuperwallKit/Config/Options/AssetResource.swift	New AssetResource protocol; URL and UIImage conformances are correctly guarded with #if canImport(UIKit).
Sources/SuperwallKit/Config/Options/SuperwallOptions.swift	Changed localResources to [String: AssetResource] with a proper ObjC bridge; localResources is excluded from Encodable via a custom CodingKeys enum.
Sources/SuperwallKit/Paywall/View Controller/Web View/LocalFileSchemeHandler.swift	Adds UIImage-to-PNG path with a static NSCache<UIImage, NSData> for repeated-request efficiency; thread-safe since NSCache is inherently thread-safe.
Sources/SuperwallKit/Paywall/View Controller/PaywallViewController.swift	Adds customCallbackRegistry dependency and syncCustomCallbackRegistration() called from init (where delegate is already set) and delegate.didSet; cleanup in deinit is correct.
Sources/SuperwallKit/Analytics/Internal Tracking/Trackable Events/TrackableSuperwallEvent.swift	Adds abandoned-transaction product attribute expansion using camelCaseToSnakeCase(); "identifier" key correctly excluded to avoid collision with abandoned_product_id.
Sources/SuperwallKit/Dependencies/DependencyContainer.swift	Moves storage.configure(apiKey:) into DependencyContainer.init so it runs synchronously; the StorageTests test validates this timing.
Sources/SuperwallKit/Paywall/Presentation/Get Paywall/PublicGetPaywall.swift	Adds onCustomCallback parameter to both the callback-based and async getPaywall overloads; default nil preserves backwards compatibility.
Tests/SuperwallKitTests/Paywall/Presentation/CustomCallbackRegistryTests.swift	New test suite covers registration on init, no-handler path, delegate reassignment (including nil clear), and deinit cleanup.
Tests/SuperwallKitTests/Identity/EmailTests.swift	Comprehensive parametrized tests for valid/invalid email addresses including trailing-newline rejection.

Sequence Diagram

sequenceDiagram
    participant App
    participant Superwall
    participant PaywallViewController
    participant CustomCallbackRegistry
    participant WebView

    App->>Superwall: getPaywall(forPlacement:, delegate:, onCustomCallback:)
    Superwall->>Superwall: internallyGetPaywall(delegate: adapter with onCustomCallback)
    Superwall->>PaywallViewController: init(customCallbackRegistry:)
    PaywallViewController->>PaywallViewController: syncCustomCallbackRegistration()
    PaywallViewController->>CustomCallbackRegistry: register(paywallIdentifier:, handler:)

    WebView-->>CustomCallbackRegistry: custom callback triggered
    CustomCallbackRegistry-->>App: invoke onCustomCallback closure
    App-->>WebView: CustomCallbackResult (.success / .failure)

    PaywallViewController->>PaywallViewController: deinit
    PaywallViewController->>CustomCallbackRegistry: unregister(paywallIdentifier:)

Loading

Comments Outside Diff (2)

1. Sources/SuperwallKit/Identity/UserAttributes.swift, line 376-391 (link)

   Case-sensitive email key matching

   The switch key comparison is case-sensitive, so attribute keys like "Email" or "EMAIL" will bypass sanitization entirely and be forwarded to the server as-is. This is inconsistent with documented API examples that show lowercase "email" and could silently let invalid emails through for callers using different casing conventions (e.g. Objective-C or legacy integrations).

   Prompt To Fix With AI

   This is a comment left during a code review.
   Path: Sources/SuperwallKit/Identity/UserAttributes.swift
   Line: 376-391
   
   Comment:
   **Case-sensitive email key matching**
   
   The `switch key` comparison is case-sensitive, so attribute keys like `"Email"` or `"EMAIL"` will bypass sanitization entirely and be forwarded to the server as-is. This is inconsistent with documented API examples that show lowercase `"email"` and could silently let invalid emails through for callers using different casing conventions (e.g. Objective-C or legacy integrations).
   
   
   
   How can I resolve this? If you propose a fix, please make it concise.

2. Sources/SuperwallKit/Identity/UserAttributes.swift, line 378-383 (link)

   PII logged in warning message

   The warning log interpolates the caller-supplied stringValue directly into the message. For a genuine (but malformed) email like "user@example" or "john.doe@company", this emits the user's actual email address to the SDK's debug log stream. Depending on the host app's logging pipeline (crash reporters, analytics SDKs), this could constitute an unintended PII leak. Consider redacting or truncating the value, e.g. printing only its length or a masked form.

   Prompt To Fix With AI

   This is a comment left during a code review.
   Path: Sources/SuperwallKit/Identity/UserAttributes.swift
   Line: 378-383
   
   Comment:
   **PII logged in warning message**
   
   The warning log interpolates the caller-supplied `stringValue` directly into the message. For a genuine (but malformed) email like `"user@example"` or `"john.doe@company"`, this emits the user's actual email address to the SDK's debug log stream. Depending on the host app's logging pipeline (crash reporters, analytics SDKs), this could constitute an unintended PII leak. Consider redacting or truncating the value, e.g. printing only its length or a masked form.
   
   
   
   How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (3): Last reviewed commit: "Always emit abandoned product attributes" | Re-trigger Greptile}