Conversation
|
you might want to look at Log::Message::Structured::Stringify::Sereal, for easy message creation. Nothing related to this PR code-wise, just connecting the dots between module... |
|
Oh, hi dams! :-) Reference noted. In this case it pretty much amount to the same thing, but indeed, it's nice to connect the dots and make sure there is no duplication. |
There was a problem hiding this comment.
Why do you need MooX::Types::MooseLike::Base here ? Seems like you never use these types ?
There was a problem hiding this comment.
On 2015-11-03 03:03 PM, Damien Krotkine wrote:
In lib/Message/Passing/Filter/Encoder/Sereal.pm
#10 (comment):@@ -0,0 +1,92 @@
+package Message::Passing::Filter::Encoder::Sereal;
+use Moo;
+use MooX::Types::MooseLike::Base qw( Bool HasMethods );Why do you need MooX::Types::MooseLike::Base here ? Seems like you never
use these types ?
Good point. I think it was a direct port (and lack of after-the-fact
cleanup) of the JSON serializer. Pushed a commit that removes that line.
Add support for Sereal