DRAFT: Update root.sfce for newer Phoenix templates#773
Open
bailey-coding wants to merge 1 commit intosurface-ui:mainfrom
Open
DRAFT: Update root.sfce for newer Phoenix templates#773bailey-coding wants to merge 1 commit intosurface-ui:mainfrom
bailey-coding wants to merge 1 commit intosurface-ui:mainfrom
Conversation
See diff below
```
git diff --cached -- lib/arw_web/components/layouts/root.html.heex lib/arw_web/components/layouts/root.sface | sed -e 's@arw@myapp@g' -e 's@Arw@MyApp@g'
diff --git a/myapp/lib/myapp_web/components/layouts/root.html.heex b/myapp/lib/myapp_web/components/layouts/root.html.heex
deleted file mode 100644
index ab9a72b..0000000
--- a/myapp/lib/myapp_web/components/layouts/root.html.heex
+++ /dev/null
@@ -1,36 +0,0 @@
-<!DOCTYPE html>
-<html lang="en">
- <head>
- <meta charset="utf-8" />
- <meta name="viewport" content="width=device-width, initial-scale=1" />
- <meta name="csrf-token" content={get_csrf_token()} />
- <.live_title default="MyApp" suffix=" · Phoenix Framework">
- {assigns[:page_title]}
- </.live_title>
- <link phx-track-static rel="stylesheet" href={~p"/assets/css/app.css"} />
- <script defer phx-track-static type="text/javascript" src={~p"/assets/js/app.js"}>
- </script>
- <script>
- (() => {
- const setTheme = (theme) => {
- if (theme === "system") {
- localStorage.removeItem("phx:theme");
- document.documentElement.removeAttribute("data-theme");
- } else {
- localStorage.setItem("phx:theme", theme);
- document.documentElement.setAttribute("data-theme", theme);
- }
- };
- if (!document.documentElement.hasAttribute("data-theme")) {
- setTheme(localStorage.getItem("phx:theme") || "system");
- }
- window.addEventListener("storage", (e) => e.key === "phx:theme" && setTheme(e.newValue || "system"));
-
- window.addEventListener("phx:set-theme", (e) => setTheme(e.target.dataset.phxTheme));
- })();
- </script>
- </head>
- <body>
- {@inner_content}
- </body>
-</html>
diff --git a/myapp/lib/myapp_web/components/layouts/root.sface b/myapp/lib/myapp_web/components/layouts/root.sface
new file mode 100644
index 0000000..4f39c41
--- /dev/null
+++ b/myapp/lib/myapp_web/components/layouts/root.sface
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html lang="en" class="[scrollbar-gutter:stable]">
+ <head>
+ <meta charset="utf-8" />
+ <meta name="viewport" content="width=device-width, initial-scale=1" />
+ <meta name="csrf-token" content={get_csrf_token()} />
+ <.live_title suffix=" · Phoenix Framework">
+ {assigns[:page_title] || "MyAppWeb"}
+ </.live_title>
+ <link phx-track-static rel="stylesheet" href={~p"/assets/app.css"} />
+ <script defer phx-track-static type="text/javascript" src={~p"/assets/app.js"}>
+ </script>
+ </head>
+ <body class="bg-white antialiased">
+ {@inner_content}
+ </body>
+</html>
```
Author
|
I can create a simpler test case with a fresh phoenix install and a fresh surface.init, if this seems legitimate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See diff below