Skip to content

baremetal_vm: Require checksum for downloaded image #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hardys merged 1 commit into from
Apr 14, 2026
Merged

baremetal_vm: Require checksum for downloaded image #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions baremetal_vm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ Variables can be stored in the script basedir as `.env` or in any file and use t
* `DISKSIZE` specifies the disk size to configure for the VM
* `IMG_TO_USE` specifies an image to locally cache and use for provisioning
* One option is `https://download.opensuse.org/pub/opensuse/distribution/leap/15.4/appliances/openSUSE-Leap-15.4-Minimal-VM.x86_64-OpenStack-Cloud.qcow2`
* `IMG_TO_USE_CHECKSUM` specifies the expected sha256 checksum for IMG_TO_USE

NOTE: Also see the [env.example](env.example) file for an example config with all options.

Expand Down
8 changes: 8 additions & 0 deletions baremetal_vm/create_vm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ source ../slemicro/common.sh
source common.sh

IMG_TO_USE=${IMG_TO_USE:-}
IMG_TO_USE_CHECKSUM=${IMG_TO_USE_CHECKSUM:-}

while getopts 'f:n:h' OPTION; do
case "${OPTION}" in
Expand Down Expand Up @@ -80,6 +81,13 @@ mkdir -p bmh-image-cache
IMG_FILENAME=$(basename ${IMG_TO_USE})
if [ ! -f bmh-image-cache/${IMG_FILENAME} ]; then
curl -Lk ${IMG_TO_USE} > bmh-image-cache/${IMG_FILENAME}

# Require checksum validation to ensure image integrity
CHECKSUM_ACTUAL=$(sha256sum "bmh-image-cache/${IMG_FILENAME}" | awk '{print $1}')
if [ "${IMG_TO_USE_CHECKSUM}" != "${CHECKSUM_ACTUAL}" ]; then
die "download sha256 does not match ${IMG_TO_USE_CHECKSUM}, got ${CHECKSUM_ACTUAL}"
fi

pushd bmh-image-cache
md5sum ${IMG_FILENAME} | tee ${IMG_FILENAME}.md5sum
popd
Expand Down
Loading