Open
Conversation
For Chinese entries, pronunciation div uses the class 'zhpron'
|
I've tested that this works. @suyash458 can you consider merging this after @claw89 fixes the conflicts? |
|
Actually, upon further testing I have found an issue: not all possible pronunciations are fetched. As an example, consider the query word Example: Output: |
|
This issue probably can't be fixed without also addressing #9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81
The list of pronunciation_div_classes in the function parse_pronunciations was missing the div class used on Chinese entries: "zhpron"