Skip to content

fix: change Explode field from bool to *bool for proper serialization #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
curiosity-the-rover wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: change Explode field from bool to *bool for proper serialization #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions encoding.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ type Encoding struct {
// For all other styles, the default value is false.
// This property SHALL be ignored if the request body media type is not application/x-www-form-urlencoded or multipart/form-data.
// If a value is explicitly defined, then the value of contentType (implicit or explicit) SHALL be ignored.
Explode bool `json:"explode,omitempty" yaml:"explode,omitempty"`
Explode *bool `json:"explode,omitempty" yaml:"explode,omitempty"`
// Determines whether the parameter value SHOULD allow reserved characters, as defined by [RFC3986]
// :/?#[]@!$&'()*+,;=
// to be included without percent-encoding.
Expand Down Expand Up @@ -138,7 +138,7 @@ func (b *EncodingBuilder) Style(v string) *EncodingBuilder {
}

func (b *EncodingBuilder) Explode(v bool) *EncodingBuilder {
b.spec.Spec.Explode = v
b.spec.Spec.Explode = &v
return b
}

Expand Down
4 changes: 2 additions & 2 deletions header.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ type Header struct {
// For other types of parameters this property has no effect.
// When style is form, the default value is true.
// For all other styles, the default value is false.
Explode bool `json:"explode,omitempty" yaml:"explode,omitempty"`
Explode *bool `json:"explode,omitempty" yaml:"explode,omitempty"`
// Determines whether this header is mandatory.
// The property MAY be included and its default value is false.
Required bool `json:"required,omitempty" yaml:"required,omitempty"`
Expand Down Expand Up @@ -118,7 +118,7 @@ func (b *HeaderBuilder) Style(v string) *HeaderBuilder {
}

func (b *HeaderBuilder) Explode(v bool) *HeaderBuilder {
b.spec.Spec.Spec.Explode = v
b.spec.Spec.Spec.Explode = &v
return b
}

Expand Down
4 changes: 2 additions & 2 deletions parameter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ type Parameter struct {
// For other types of parameters this property has no effect.
// When style is form, the default value is true.
// For all other styles, the default value is false.
Explode bool `json:"explode,omitempty" yaml:"explode,omitempty"`
Explode *bool `json:"explode,omitempty" yaml:"explode,omitempty"`
// Determines whether the parameter value SHOULD allow reserved characters, as defined by [RFC3986]
// :/?#[]@!$&'()*+,;=
// to be included without percent-encoding.
Expand Down Expand Up @@ -370,7 +370,7 @@ func (b *ParameterBuilder) Name(v string) *ParameterBuilder {
}

func (b *ParameterBuilder) Explode(v bool) *ParameterBuilder {
b.spec.Spec.Spec.Explode = v
b.spec.Spec.Spec.Explode = &v
return b
}

Expand Down