fix: stop silently dropping TypeScript markers when printing#135
Merged
Conversation
Several modifiers and type parameters were omitted from the output, changing a program's type contract while still producing valid-looking code: - optional parameters (a?: T) lost their ? (Identifier handler) — functions, arrows, methods, and call/construct/method signatures - class fields lost ?, !, readonly, declare, override (PropertyDefinition) - classes and methods lost their type parameters (class A<T>, m<T>()) - type-parameter modifiers const / in / out were dropped (TSTypeParameter) - mapped-type readonly/? modifiers (incl. +/-) and 'as' key-remapping were dropped (TSMappedType) Adds test/ts-markers.test.js covering each. No existing snapshots change.
🦋 Changeset detectedLatest commit: caf4586 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
guyutongxue
added a commit
to piovium/espolar
that referenced
this pull request
Jun 3, 2026
Member
|
Was about to approve, but found one remaining thing? Why did you not use the existing testing pattern for and created custom tests for that? I think i missed that in the PR i merged a couple of minutes ago as well. LMK if you need help with that. |
jycouet
approved these changes
Jun 26, 2026
manuel3108
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes cases where esrap silently dropped TypeScript markers from the output:
a?: T)?,!,readonly,declare,overrideclass A<T>,m<T>())const/in/outreadonly/?modifiers (incl.+/-) andaskey-remapping