fix: print valid TypeScript for asserts predicates, qualified namespaces, and computed signature keys#137
Open
MathiasWP wants to merge 1 commit into
Open
Conversation
…ces, and computed signature keys
These were emitted as invalid output:
- asserts type predicates printed in the wrong order: asserts x is T -> x asserts T
- qualified namespace/module names mangled: namespace A.B.C ->
namespace Anamespace Bnamespace C
- computed method/property signature keys lost their brackets:
interface I { [Symbol.iterator](): T } -> Symbol.iterator(): T
Adds test/ts-token-emission.test.js.
🦋 Changeset detectedLatest commit: e398da2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
guyutongxue
added a commit
to piovium/espolar
that referenced
this pull request
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three TypeScript constructs that esrap was printing as invalid output:
assertstype predicates were printed in the wrong order (asserts x is Tbecamex asserts T)namespace A.B.Cbecamenamespace Anamespace Bnamespace C)interface I { [Symbol.iterator](): T }becameSymbol.iterator(): T)