fix: reimplement treeshaking non-dynamic prerendered remote functions#15447
Open
fix: reimplement treeshaking non-dynamic prerendered remote functions#15447
Conversation
🦋 Changeset detectedLatest commit: 25a685f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
… into treeshake-prerendered
Member
Author
|
We probably need to fix up any sourcemaps too after the treeshaking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression where prerendered remote functions were no longer treeshaken. It was accidentally removed in https://github.com/sveltejs/kit/pull/14293/changes#diff-6997ee961e0605b37d712e389f6a938a4ae080038f0ed9b9643894b287985feaL51 while we were trying to figure out how to make remote functions in node_modules work correctly.
It also ensures that these prerendered functions can't be called in production with arbitrary inputs. cc: @GauBen
EDIT: In retrospect, this doesn't help remove certain files if they aren’t in use by anyone after the treeshaking occurred.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits