fix: handle target attribute on remote form redirects#15457
Merged
teemingc merged 10 commits intosveltejs:mainfrom Mar 6, 2026
Merged
fix: handle target attribute on remote form redirects#15457teemingc merged 10 commits intosveltejs:mainfrom
teemingc merged 10 commits intosveltejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: e530b52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
Contributor
Author
|
@teemingc can you please review this PR ? Thank you |
teemingc
reviewed
Mar 5, 2026
packages/kit/src/runtime/client/remote-functions/form.svelte.js
Outdated
Show resolved
Hide resolved
teemingc
reviewed
Mar 5, 2026
packages/kit/src/runtime/client/remote-functions/form.svelte.js
Outdated
Show resolved
Hide resolved
teemingc
reviewed
Mar 5, 2026
packages/kit/src/runtime/client/remote-functions/form.svelte.js
Outdated
Show resolved
Hide resolved
teemingc
reviewed
Mar 5, 2026
teemingc
reviewed
Mar 5, 2026
teemingc
reviewed
Mar 5, 2026
packages/kit/test/apps/async/src/routes/remote/form/redirect-target/+page.svelte
Show resolved
Hide resolved
teemingc
requested changes
Mar 5, 2026
Member
teemingc
left a comment
There was a problem hiding this comment.
Thanks for the PR! There are some additional edge cases we need to account for which I've highlighted in the comments. Also, there might be a way to simplify the window opening handling.
Contributor
Author
|
Hey @teemingc, thanks for the detailed review. I have updated the code and yes there was a better way of handling this, I tried to implement that and also added an additional test. |
teemingc
reviewed
Mar 5, 2026
packages/kit/src/runtime/client/remote-functions/form.svelte.js
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15197
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits
Problem
Remote forms with
target="_blank"did not open the redirect destination in a new tab. Instead, the current tab would navigate to the redirect URL, makingtarget="_blank"completely ignored for both internal and external redirects.Solution
Check the form element's target attribute before deciding how to navigate. If it's
_blankor_new, usewindow.open()instead of_goto()I have ran all the tests and there were no issues.