fix: return sourcemaps from vite-plugin-sveltekit-remote transform hook#15473
Open
DJMogens wants to merge 3 commits intosveltejs:mainfrom
Open
fix: return sourcemaps from vite-plugin-sveltekit-remote transform hook#15473DJMogens wants to merge 3 commits intosveltejs:mainfrom
DJMogens wants to merge 3 commits intosveltejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: e7ea2ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4e2e97a to
94d5b3c
Compare
94d5b3c to
d07b5e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
transformhook inplugin_remote(src/exports/vite/index.js) modifies.remote.*files but doesn't return amapproperty in either code path. This causes:[plugin vite-plugin-sveltekit-remote] Sourcemap is likely to be incorrect— once per.remote.*file, for both SSR and client builds..js.mapfiles havesources: [],sourcesContent: [], and semicolon-onlymappings. Error monitoring tools (e.g. Sentry) cannot map stack traces back to the original source.Per the Vite Plugin API docs,
transformhooks should return{ code, map }.Closes #15472
Changes
SSR path (~line 727): Uses
MagicString(already a dependency) instead of string concatenation, returns{ code, map }with a proper sourcemap viams.generateMap({ hires: true }).Client path (~line 803): Adds
map: { mappings: '' }to signal intentional full module replacement (the generated proxy code doesn't need source mapping back).Testing
Reproduction repo with
build:bug/build:fixscripts: https://github.com/DJMogens/sveltejs-kit-sourcemap-bugpnpm formatpasses