Skip to content

chore: bump peer dep version for SvelteKit#15494

Open
teemingc wants to merge 2 commits intoversion-3from
cloudflare-todos
Open

chore: bump peer dep version for SvelteKit#15494
teemingc wants to merge 2 commits intoversion-3from
cloudflare-todos

Conversation

@teemingc
Copy link
Member

@teemingc teemingc commented Mar 5, 2026

Part of #1247

Removes some TODOs that we wanted to get done for the next adapter major such as ensuring new Kit features are always available by bumping the peer dep and removing workarounds for ambient types not being available (they are now)


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2026

⚠️ No Changeset found

Latest commit: da1cad1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

},
"peerDependencies": {
"@sveltejs/kit": "^2.0.0",
"@sveltejs/kit": "^2.31.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary change. This will be 3.0.0 later on anyway

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you intend to merge this PR now and update it later or are you planning on leaving this PR until right before the 3.0 release?

Copy link
Member Author

@teemingc teemingc Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intend to merge it now but I wasn't sure if we could change this to ^3.0.0 already. Can we?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can make it ^3.0.0 now. you'll get a peer dependency warning if trying to use with ^3.0.0-next.0 unless you make that in the range but I think that fine. and it's better than it warning that you're not using ^2.31.0, so might as well go ahead and do it now

},
"peerDependencies": {
"@sveltejs/kit": "^2.0.0",
"@sveltejs/kit": "^2.31.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you intend to merge this PR now and update it later or are you planning on leaving this PR until right before the 3.0 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants