breaking: forbid external redirects by default#16198
Open
dummdidumm wants to merge 3 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 3b529bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Comment on lines
+109
to
+110
| BROWSER + | ||
| (BROWSER ? window.location.href : try_get_request_store()?.event.request.url) |
Contributor
There was a problem hiding this comment.
Suggested change
| BROWSER + | |
| (BROWSER ? window.location.href : try_get_request_store()?.event.request.url) | |
| ` (redirect attempted from ${BROWSER ? window.location.href : try_get_request_store()?.event.request.url})` |
The DEV error message for a forbidden external redirect concatenates the raw BROWSER boolean into the message string, producing a malformed message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You now have to pass
{ external: string[] | boolean }toredirectif you want to redirect to an external URL (or ajavascript:URL).Closes #15131