feat: show error in dev tools when using unsupported Svelte version#243
Open
Kolby11 wants to merge 1 commit intosveltejs:masterfrom
Open
feat: show error in dev tools when using unsupported Svelte version#243Kolby11 wants to merge 1 commit intosveltejs:masterfrom
Kolby11 wants to merge 1 commit intosveltejs:masterfrom
Conversation
| <footer> | ||
| <p style:font-size="1rem">Svelte app is using an unsupported major version.</p> | ||
| <ul> | ||
| <li>Currently using Svelte version ^{app.svelteVersion}.0.0</li> |
There was a problem hiding this comment.
Is there a reason to show the version with .0.0 appended? That seems like it could be confusing since it might not match the actual patch version in use, and it looks like the supported versions aren't displayed that way.
Author
There was a problem hiding this comment.
I mean it has "^" character prepended which is a technically correct term. Since i have not found any way to find the minor and patch version, only the major one, I decided to stick with the convention from this message.
<li>Use Svelte version ^4.0.0?</li>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added display of unsupported Svelte version message in dev tools.
Also implemented Svelte version detection per browser tab, fixing an unrelated bug where the Svelte logo style would change across different browser windows based on the active tab.
Closes #242