fix: update shell-missing/unsupported tests to expect zero exit#40
Open
sven1103-agent wants to merge 1 commit intomainfrom
Open
fix: update shell-missing/unsupported tests to expect zero exit#40sven1103-agent wants to merge 1 commit intomainfrom
sven1103-agent wants to merge 1 commit intomainfrom
Conversation
The installer gracefully handles missing or unsupported SHELL — it installs the binary successfully (exit 0) and skips RC file updates. The tests were expecting non-zero exit and no filesystem changes, which no longer matched the installer's actual behavior. Also fix test-release-opencode-helper-bundle mode from 0644 to 0755.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_yes_shell_missing_no_changesandtest_yes_shell_unsupported_no_changesto expect exit 0 (installer gracefully handles missing/unsupported SHELL, installs binary successfully, skips RC updates)test-release-opencode-helper-bundleexecutable (mode 0644 → 0755)