Remove streaming dependencies and move to StreamCallbacks.jl#307
Open
Sixzero wants to merge 3 commits intosvilupp:mainfrom
Open
Remove streaming dependencies and move to StreamCallbacks.jl#307Sixzero wants to merge 3 commits intosvilupp:mainfrom
Sixzero wants to merge 3 commits intosvilupp:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage ? 92.62%
=======================================
Files ? 37
Lines ? 3242
Branches ? 0
=======================================
Hits ? 3003
Misses ? 239
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all streaming-related dependencies and implementation from PromptingTools.jl and moves them to the dedicated StreamCallbacks.jl package.
Summary of changes
Changes Made
Removed Dependencies:
StreamCallbacksfrom direct dependencies inProject.tomlRefactored Streaming Interface:
src/streaming.jlAbstractStreamCallbacktype for extensibilityconfigure_callback!,streamed_request!) as stubsUpdated Documentation:
aigeneratefunctions across all schemas (OpenAI, Anthropic, Ollama)using StreamCallbacksfor streaming functionalityTest Cleanup:
test/streaming.jlas streaming tests are now in StreamCallbacks.jlBenefits
using StreamCallbacksMigration for Users
Users who use streaming features need to add one line:
Breaking Changes
PT.StreamCallback) now requiresusing StreamCallbacksThis change improves the package architecture while maintaining full backward compatibility for end users.