Implement LibCURL-based streaming with improved error handling#16
Implement LibCURL-based streaming with improved error handling#16Sixzero wants to merge 11 commits intosvilupp:mainfrom
Conversation
- Add libcurl_streamed_request! with cleaner stack traces - Better error messages on API response failures - Examples in long_context_test.jl and error_handling_test.jl - Output comparisons will be posted in PR
|
The goal is to eventually switch away from the HTTP.jl solution, since they cannot reduce the size of the stacktrace, according to slack conversations, also I posted this for them: JuliaWeb/HTTP.jl#1216 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
===========================================
- Coverage 86.81% 67.52% -19.30%
===========================================
Files 6 7 +1
Lines 273 351 +78
===========================================
Hits 237 237
- Misses 36 114 +78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Runing the long_context_test.jl: New LibCURL.jl error: I think we can clearly see what is my problem with HTTP.jl here. I 'll post the other test's output. |
|
Running LibCURL: Again the results speaks clearly for themselves. Immagine how many times there is some fault in the API call and you would need the error. |
|
I would also propose the removal of |
Also slight dispatch adjustments for streamed_requests.
Key advantages
libcurl_streamed_request!with cleaner stack tracesNotes:
long_context_test.jlanderror_handling_test.jlI think there was an error in the throw_on_error, because Exception didn't have Exception(::String) initialization.
P.S: Output comparisons will be posted later