Support zip installers natively without calling winget on target machines#259
Merged
svrooij merged 3 commits intoJul 3, 2026
Merged
Conversation
Copilot
AI
changed the title
[WIP] Implement NestedInstallerType handling in WinGet manifest
Handle NestedInstallerType in WinGet manifest
Jul 3, 2026
Copilot
AI
changed the title
Handle NestedInstallerType in WinGet manifest
Support zip installers natively without calling winget on target machines
Jul 3, 2026
svrooij
marked this pull request as ready for review
July 3, 2026 19:25
svrooij
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages with
InstallerType.Zip(e.g. Adobe Acrobat Pro) previously fell back to a winget-based install script, requiring winget on the target machine. This adds zip as a first-class installer type by downloading, extracting, and packaging the nested installer directly.Changes
ComputeBestInstallerForPackageCommand.cscase InstallerType.ZipinComputeInstallerCommands()to deriveInstallCommandLine/UninstallCommandLinefromNestedInstallerFilesandInstallerSwitchesmsiexec /i "nestedPath" <switches>"nestedPath" <switches>, uninstall viaMsiProductCodeif presentIntuneManager.cselse ifbranch inGenerateNoneMsiInstallerfor zip packages with nested files: downloads the zip, extracts it to the output folder, setsInstallerFilenameto the nested relative pathTests
adobeAcrobatZipPackageInfoconstant (zip with nested exe atAdobe Acrobat\setup.exe, EULA switches, product code)GenerateInstallerPackage_ZipPackage_ExtractsAndPackagesNestedInstallertest covering the full flow