Draft
Fix -PreferedInstaller being ignored for zip packages with NestedInstallerType#266
Conversation
2 tasks
When a package uses InstallerType: zip with NestedInstallerType (e.g., wix), the installer matching logic in singleOrDefault now also considers the NestedInstallerType when the user specifies a PreferedInstaller. This means that specifying `-PreferedInstaller Wix` for a package like dotPDN.PaintDotNet (which uses a zip container wrapping a wix installer) will now correctly select the zip installer with the matching nested type. Fixes #265
Copilot
AI
changed the title
[WIP] Fix ignored PreferedInstaller for NestedInstaller packages
Fix -PreferedInstaller being ignored for zip packages with NestedInstallerType
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For packages like
dotPDN.PaintDotNetthat useInstallerType: zipwith aNestedInstallerType: wix, specifying-PreferedInstaller Wixhad no effect — the matcher only checked the outerInstallerTypefield ("zip"), never matching "wix".Changes
WingetInstallerExtensions: ExtendedsingleOrDefaultto also match a zip installer when itsNestedInstallerTypeequals the requested type. Logic extracted into a newInstallerTypeMatcheshelper:PackageInfounit tests verifying thatInstallerType.Wixpreference selects a zip+wix installer, plus aWingetManagerintegration test for the PaintDotNet manifest (zip outer / wix nested).